Port Verdict to GPUs #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
adayton1
commented
Nov 19, 2024
|
|
||
| static const double one_third = 1.0 / 3.0; | ||
| static const double two_thirds = 2.0 / 3.0; | ||
| static const double sqrt3 = std::sqrt(3.0); |
There was a problem hiding this comment.
Would you prefer if I did something like the following so that sqrt3 is a constant on the host rather than always recomputed?
VERDICT_HOST_DEVICE static double sqrt3()
{
#if defined(VERDICT_DEVICE_COMPILE)
return sqrt(3);
#else
static const double s_sqrt3 = sqrt(3);
return s_sqrt3;
#endif
adayton1
commented
Nov 19, 2024
| double warpage = std::pow( | ||
| std::min(corner_normals[0] % corner_normals[2], corner_normals[1] % corner_normals[3]), 3); | ||
| double warpage = fmin(corner_normals[0] % corner_normals[2], corner_normals[1] % corner_normals[3]); | ||
| warpage = warpage * warpage * warpage; |
There was a problem hiding this comment.
The c pow function is much slower for integer exponents than manually multiplying. Is this change acceptable or would you like me to write a cube function?
adayton1
commented
Nov 19, 2024
|
|
||
| /* quality functions for hex elements */ | ||
|
|
||
| //! Calculates hex edge ratio metric. | ||
| /** Hmax / Hmin where Hmax and Hmin are respectively the maximum and the | ||
| minimum edge lengths */ | ||
| VERDICT_EXPORT double hex_edge_ratio(int num_nodes, const double coordinates[][3]); | ||
| VERDICT_EXPORT VERDICT_HOST_DEVICE double hex_edge_ratio(int num_nodes, const double coordinates[][3]); |
There was a problem hiding this comment.
I could fold in VERDICT_HOST_DEVICE into the definition of VERDICT_EXPORT if desired.
adayton1
commented
Nov 19, 2024
| @@ -4,10 +4,30 @@ | |||
|
|
|||
| cmake_minimum_required(VERSION 3.16) | |||
|
|
|||
| set(CMAKE_CXX_STANDARD 11) | |||
| set(CMAKE_CXX_STANDARD_REQUIRED 1) | |||
| set(CMAKE_CXX_STANDARD 11 CACHE STRING "") | |||
There was a problem hiding this comment.
This change allows applications to build with newer c++ standards while leaving 11 as the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__host__ __device__specifiers to all functions