Skip to content

Commit

Permalink
resolving nitpicks
Browse files Browse the repository at this point in the history
  • Loading branch information
CoderOfTheLight authored and GhostofGoes committed Jan 9, 2025
1 parent 13f265b commit dd12576
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/python/phenix_apps/apps/scorch/disruption/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ components:
## Notes and Considerations
* for a cyber_physical experiment, if overall run_time is shorter than combined dos.start_delay plus dos.attack_duration or physical.start_delay plus 5 minutes (whichever is longer), then phenix will fail because dos did not have enough time to export results or physical is not finished.
* for a cyber_physical experiment, if dos.start_delay is longer than the overall run_time, there is no no check shorten dos.start_delay in relation to dos.attack_duration. There is only a check to shorten dos.attack_duration.
* for a cyber_physical experiment, if dos.start_delay is longer than the overall run_time, there is no check shorten dos.start_delay in relation to dos.attack_duration. There is only a check to shorten dos.attack_duration.
* for a cyber_physical/dos/physical experiment, if combined dos.start_delay plus dos.attack_duration or physical.start_delay plus 5 minutes exactly equal the overall run_duration, then phenix will fail because dos and physical will not have enough time to wrap up.
* for a cyber_physical/physical experiment, there is no check to see if physical.start_delay is larger than the overall run_duration
* for a cyber_physical/physical experiment, there is hard requirement that run_duration must be slightly longer than the physical.start_delay plus the physical run duration or the experiment will fail. Physical run duration is varied and cannot be extended or shortened from this configuration.
Expand Down
3 changes: 1 addition & 2 deletions src/python/phenix_apps/apps/scorch/disruption/disruption.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def start(self):
self.print(f"sleeping for {physical_start_delay} seconds")
sleep(physical_start_delay)

# attack duration
# physical duration
elapsed = self._run_physical_disruption(physical_start_delay)

# sleep until experiment run_duration time is up, physical ended early
Expand All @@ -212,7 +212,6 @@ def start(self):

# Kick off DoS process, have it sleep for number of seconds that puts it between line outage and load shedding
# delay: 6.0 = 2.0 + 4.0 + 60.0 = 66.0
#dos_start_delay = 2.0 + 4.0 + start_delay # 66.0
# using config data dos_start_delay instead

# run dos attack with start delay as a background process
Expand Down

0 comments on commit dd12576

Please sign in to comment.