Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videojs setup rework #460

Merged
merged 15 commits into from
Apr 25, 2024
Merged

Videojs setup rework #460

merged 15 commits into from
Apr 25, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Mar 26, 2024 •
edited
Loading

Related issue: #399

@Dananji Dananji force-pushed the videojs-setup-rework branch 2 times, most recently from 46ec914 to 65f645d Compare April 2, 2024 21:06
@Dananji Dananji marked this pull request as ready for review April 4, 2024 20:47
@Dananji Dananji force-pushed the videojs-setup-rework branch from c9a2974 to afe83cc Compare April 9, 2024 17:04
Dananji added 13 commits April 19, 2024 15:33
@Dananji
[WIP] Init Video.js once -> re-use for consecutive Canvas changes
243dabe
@Dananji
Fix markers setup on Video.js initialization
927a293
@Dananji
Add missing code from rebase and fix building and updating tracks obj…
8e02b04 
…ects
@Dananji
WIP: try updating the custom components on reload
61863fd
@Dananji
Fix updating custom Video.js components with src change
d4dd4d6
@Dananji
Some code cleanup and fixes to structured nav, playlist manifest rend…
b2a9612 
…ering, volume panel styling
@Dananji
Fix player crashing on ended event for inaccessible items
1818a68
@Dananji
[WIP] Testing cookbook recipes
a5515c8
@Dananji
Fix rendering for cookbook recipe 64
2b115a7
@Dananji
Fix track scrubber updates on Canvas changes
25da9a4
@Dananji
Cleanup code, fix failing tests, and fix playlist markers in player
203ba65
@Dananji
Reset file download custom component on player reload
d486c4f
@Dananji
Rebase from main, fix canvasDuration for VideoJSPlayer
c2933e7
@Dananji Dananji force-pushed the videojs-setup-rework branch from afe83cc to c2933e7 Compare April 19, 2024 19:37
@Dananji Dananji force-pushed the videojs-setup-rework branch from 771cea4 to 3b8d7b1 Compare April 19, 2024 19:40
masaball
masaball reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is looking good to me. Just had a couple non-blocking housekeeping things and a question about hopefully simplifying the player update.

src/components/MediaPlayer/VideoJS/VideoJSPlayer.js Show resolved Hide resolved
src/components/MediaPlayer/VideoJS/VideoJSPlayer.js Show resolved Hide resolved
src/components/MediaPlayer/VideoJS/components/js/VideoJSProgress.js Outdated Show resolved Hide resolved
@Dananji
Copy link
Collaborator Author

Dananji commented Apr 23, 2024

Need to squash and merge

@Dananji Dananji merged commit cfef323 into main Apr 25, 2024
2 checks passed
@Dananji Dananji deleted the videojs-setup-rework branch April 25, 2024 13:26
@Dananji Dananji mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @masaball