Fix sprite transparency to check for non-zero bits #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pico 8 seems to only care that the transparency nibble in the palette is non-zero, but before this fix zepto8 was checking that it was exactly 1. I don't see this difference explicitely spelled out in the offial docs, but the wiki does say "non-zero". This seems to only affect carts that are pokeing the draw state. One example that is fixed is Dank Tomb, where the green background of the character sprite was visible, but is not after this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pico-8 seems to only care that the transparency nibble in the draw palette is non-zero, but before this fix zepto8 was checking that it was exactly 1. I don't see this difference explicitly spelled out in the official docs, but the wiki does say "non-zero" (https://pico-8.fandom.com/wiki/Memory#Draw_state).
This seems to only affect carts that are
pokeing the draw state. One example that is fixed is Dank Tomb, where the green background of the character sprite was visible in zepto8, but is not after this fix.