Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the imports problem - added cosmos_helpers #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vykhand
Copy link

@vykhand vykhand commented Mar 24, 2023

No description provided.

Copy link
Owner

@samelhousseini samelhousseini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrey, just wanted to check with you, why the addition of cosmos_helpers here? The original code does not use cosmos in this py file, was it something you added as custom code?

@vykhand
Copy link
Author

vykhand commented Mar 30, 2023

Hey Samer, I see that you removed cosmos_helpers in the commit from yesterday, and as of 27.03 it was still there :) I hit this issue because I specified the non-existing base model, and it hit the OldSchoolSearch.py, and failed with missing import. BTW after adding the import back, it went into an infinite loop when the base model was not correct, and I could not debug why, may be it is also fixed. So, feel free to discard this PR

@samelhousseini
Copy link
Owner

samelhousseini commented Mar 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants