This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
New method to list containers (with missing parameters) #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // ListContainersWithOptions behaves like ListContainers but allowing additionnal options | ||
| func (client *DockerClient) ListContainersWithOptions(all, size bool, limit, since, before, filters string) ([]Container, error) { |
There was a problem hiding this comment.
I think these options would be nicer as a struct, something like:
type ListContainerOptions struct {
All, Size bool
Limit, Since, Before, Filters string
}
|
can you also add the new method to the interface in interface.go and to the mock in mockclient/mock.go? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left the existing "client.ListContainers" method but created a "client. client.ListContainersWithOptions" method.
It does the same thing, but allows 3 additional parameters to be provided : "limit", "since" and "before".
The goal is to have the same options than in the docker CLI.