SALTO-7356: block system generated fields deployment #7202
+187
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayc331
approved these changes
Feb 3, 2025
| }) | ||
|
|
||
| const jsmFieldToTemplateName = (field: string): string | undefined => { | ||
| const map = PROJECT_TEMPLATE_TO_FIELDS() |
There was a problem hiding this comment.
why is it a function and not a constant?
I find it weird to use a function with SCREAMING_SNAKE_CASE
| }) | ||
|
|
||
| const jsmFieldToTemplateName = (field: string): string | undefined => { | ||
| const map = PROJECT_TEMPLATE_TO_FIELDS() |
There was a problem hiding this comment.
please rename map to something more informative
| @@ -41,12 +38,12 @@ const jsmFieldToTemplateName = (field: string): string => { | |||
| } | |||
|
|
|||
| export const lockedFieldsValidator: ChangeValidator = async changes => | |||
| awu(changes) | |||
| changes | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those fields can be created by Atlassian and create duplicates, we should not deploy them
See ticket for more information.
I checked only the 3 templates that were the major ones in the previous one, there might be additional fields in the other templates.
Please also review the article, I will publish it once approved and update the reference in the CV accordingly
Release Notes:
Jira Adapter:
User Notifications:
None