SALTO-6994: Avoid redundant copy of fetch changes (#6863)

salto-io · Nov 28, 2024 · 9619142 · 9619142
1 parent 22bcdf8
commit 9619142
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/cli/src/commands/fetch.ts b/packages/cli/src/commands/fetch.ts
@@ -222,19 +222,17 @@ export const fetchCommand = async ({
     }
   }
 
-  // Unpack changes to array so we can iterate on them more than once
-  const changes = [...fetchResult.changes]
-  cliTelemetry.changes(changes.length)
+  cliTelemetry.changes(fetchResult.changes.length)
 
   const updatingWsSucceeded = stateOnly
-    ? await applyChangesToState(changes)
+    ? await applyChangesToState(fetchResult.changes)
     : await applyChangesToWorkspace({
         workspace,
         cliTelemetry,
         force,
         shouldCalcTotalSize,
         output,
-        changes,
+        changes: fetchResult.changes,
         mode,
         approveChangesCallback: getApprovedChanges,
         applyProgress: fetchProgress,

diff --git a/packages/core/src/core/fetch.ts b/packages/core/src/core/fetch.ts
@@ -204,7 +204,7 @@ const toChangesWithPath =
 
     const originalElements = accountElementByFullName(changeID)
     if (originalElements.length === 0) {
-      log.trace(`no original elements found for change element id ${changeID.getFullName()}`)
+      log.debug('no original elements found for change element id %s', changeID.getFullName())
       return [change]
     }