Add Travis, Badges, and fixed all linting errors (RC 2.0.0) #18
Conversation
|
Should I roll #6 into this as well since all breaking API changes should probably get captured here? |
|
@tchap license headers in that format actually violate the linters. If you move the license headers into a COPYING or as an additional LICENSE file, those satisfy legal requirements of copyright protection (I've dealt with open sourcing things a few times with my company's legal team). They were also sparsely placed. Do you want them everywhere? |
|
@king-jam If you know without searching how to do it, could you just copy what is necessary into COPYING? Otherwise I will do something about this when merged... |
|
I was looking at the linting errors more closely and it just required a newline between the header and the package declaration. I opted to just update them in place. I agree that a change like that should be a separate commit and more planned. |
|
I think tweaking #6 should wait until after this merge. Cutting a release locks in Glide/Dep/go mod/etc so tweaking the 2.0.0 interface doesn't need to be rushed in a large giant commit. |
|
@king-jam So are we good to merge or is there anything else left? Thanks for the effort. |
|
I think we are good to merge. |
|
@king-jam I am wondering about naming still, there are many fields named like |
|
If there are, I absolutely missed them and will need to fix. Seems like plural versions pass linters. |
|
Looks good. Do you think that you could rebase and squash what makes sense to get nicer commits? Like, we definitely don't need what was committed and reverted again. The badge commits can be merged together as well. Thanks! |
|
Definitely. Was going to with that last commit but didn't want to lose any of the simpler diffs. |
|
Squashed! |
You'll need to enable https://travis-ci.com on the repo (it is free because it's a public repo) but then that feature should start working.
Closes: #17