Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spells in the current beta #44

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

ashleybaldock
Copy link
Collaborator

@ashleybaldock ashleybaldock commented Jul 6, 2023

Add spells/icons for:

anti_homing
bounce_hole
bounce_lightning
bounce_small_explosion
caster_cast
fish
homing_wand
hook
sea_swamp
true_orbit
white_hole_big
zero_damage
  • Adds basic support for having a beta version, with two sets of actions/etc. (can improve this later if needed)
  • Toggle display of beta spells via config option + options for the unlockable ones

One of the spells, null shot, has added a unique damage_null_all flag/value - not sure what exactly this does since it isn't in the lua side of things. May have to refine behaviour in future.

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
noita-wand-simulator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2023 6:36pm

@ashleybaldock ashleybaldock added enhancement New feature or request WIP Work in progress - not ready to merge labels Jul 6, 2023
@ashleybaldock ashleybaldock removed the WIP Work in progress - not ready to merge label Jul 7, 2023
src/app/calc/evaluate_lua/__generated__

src/app/calc/__generated__/*.ts
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this since it will keep the formatting of these consistent with the output of the script, meaning clearer diffs.

@ashleybaldock
Copy link
Collaborator Author

ashleybaldock commented Aug 20, 2023

This needs updating before it's worth merging (doesn't cover the latest beta changes, the *plicate spells need work). Also needs a way to turn the beta changes on/off since they affect existing spells as well as adding new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add new spells in forthcoming update
1 participant