Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency cleanup [skip-validate-pr] #500

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Sep 28, 2022

What does this PR do?

remove cli-ux in favor of its equivalent from oclif/core
remove [seemingly] unused npm dependencies

What issues does this PR fix or reference?

[skip-validate-pr]

@git2gus
Copy link

git2gus bot commented Sep 28, 2022

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

Copy link
Contributor

@mdonnalley mdonnalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. However, you could do the following:

  • make sure the Flags import is coming from sf-plugins-core instead of oclif/core
  • replace CliUx.ux with the corresponding methods on SfCommand, e.g. CliUx.ux.action.start/stop => this.spinner.start/stop, CliUx.ux.table => this.table

README.md Outdated Show resolved Hide resolved
@mshanemc
Copy link
Contributor Author

  • make sure the Flags import is coming from sf-plugins-core instead of oclif/core

seemed fine. I left one that was importing oclif command, too.

  • replace CliUx.ux with the corresponding methods on SfCommand, e.g. CliUx.ux.action.start/stop => this.spinner.start/stop, CliUx.ux.table => this.table

their UT didn't like that (even just the spinners) so I reverted that

@mshanemc mshanemc changed the title chore: dependency cleanup chore: dependency cleanup [skip-pr-validate] Sep 28, 2022
@mshanemc mshanemc changed the title chore: dependency cleanup [skip-pr-validate] chore: dependency cleanup [skip-validate-pr] Sep 28, 2022
Base automatically changed from sm/gha to main October 20, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants