-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dependency cleanup [skip-validate-pr] #500
Draft
mshanemc
wants to merge
7
commits into
main
Choose a base branch
from
sm/cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git2Gus App is installed but the |
mdonnalley
requested changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. However, you could do the following:
- make sure the
Flags
import is coming fromsf-plugins-core
instead ofoclif/core
- replace
CliUx.ux
with the corresponding methods onSfCommand
, e.g.CliUx.ux.action.start/stop
=>this.spinner.start/stop
,CliUx.ux.table
=>this.table
seemed fine. I left one that was importing oclif command, too.
their UT didn't like that (even just the spinners) so I reverted that |
mshanemc
changed the title
chore: dependency cleanup
chore: dependency cleanup [skip-pr-validate]
Sep 28, 2022
mshanemc
changed the title
chore: dependency cleanup [skip-pr-validate]
chore: dependency cleanup [skip-validate-pr]
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
remove cli-ux in favor of its equivalent from oclif/core
remove [seemingly] unused npm dependencies
What issues does this PR fix or reference?
[skip-validate-pr]