Update 'typescript-eslint/utils' to dependency #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifeng-li-at-salesforce
requested review from
khawkins,
sfdctaka,
maliroteh-sf and
ben-zhang-at-salesforce
as code owners
|
Did you wanted @typescript-eslint/utils NOT to appear in host package's node_modules? Wouldn't putting it in dependencies actually do just that? |
@sfdctaka It's a dependency that is required by the plugin package at runtime, which is the reason for the move. Without it, if you install the plugin and attempt to run it, you will get errors about the missing dependency from ESLint. |
ben-zhang-at-salesforce
approved these changes
Dec 4, 2024
khawkins
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
eslint-plugin-lwc-mobileis installed as devDependency, the 'typescript-eslint/utils' would show up in 'node_modules'