-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint rule mutation not supported #6
Conversation
src/rules/graphql/types.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types provides additional information for TypeScript compiler. Especially GraphQLESTreeNode
allows developers to take advantage of ESLintTreeNode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost peer coded , looks good to me
docs: { | ||
description: 'mutation is not supported offline', | ||
category: 'Operations', | ||
recommended: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The url will be added once Takashi's apex pr is merged, will use uplift his url generation logic to be used by all rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks pretty good to me! Just some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
W-15782130
graphql local eval doesn't support graphql mutation yet. This eslint rule warns lwc developer if the crafted graphql statement has mutation operation.
The below is the screenshot from
offline-app-developer-starter-kit
which installs our plugin.