Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow End Users to use the PATCH method for the V8 API #10623

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

kale1d0code
Copy link
Contributor

enables the ability to update CRM Records from the V8 API

Description

The CRM is sending CORS headers.
The CRM does not allow the PATCH method which prevents users from updating existing records within the CRM

Motivation and Context

It is not possible to update records over the API without this change,
or it is required to fix the headers upstream within a reverse proxy web server.

How To Test This

run a PATCH method request

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

enables the ability to update CRM Records from the API
Copy link
Member

@mattlorimer mattlorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mattlorimer mattlorimer added Status: Passed Code Review Mark issue has passed code review reviewed PR 1-3 Complexity Score given to PRs once assessed labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR 1-3 Complexity Score given to PRs once assessed Status: Passed Code Review Mark issue has passed code review reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants