Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix showing proper highlight index when value is object in Combobox #815

Merged
merged 18 commits into from
Jul 22, 2024
Merged

Fix showing proper highlight index when value is object in Combobox #815

merged 18 commits into from
Jul 22, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Jun 28, 2024

I want to merge this change because...

This PR closes #...

Screenshots

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • The storybook story is created and documentation is properly generated.
  • New component is wrapped in forwardRef.

@poulch poulch requested a review from a team as a code owner June 28, 2024 14:15
@poulch poulch requested review from andrzejewsky and Cloud11PL and removed request for a team June 28, 2024 14:15
@vercel Vercel
Copy link

vercel bot commented Jun 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 10:23am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c641e81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/macaw-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

krzysztofzuraw
krzysztofzuraw previously approved these changes Jun 28, 2024
View reviewed changes
krzysztofzuraw
krzysztofzuraw previously approved these changes Jul 2, 2024
View reviewed changes
@poulch poulch added release dev tag Release pkg to npm with @dev tag labels Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240702074732.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240702074738.

Install it with:

pnpm add @saleor/[email protected]

@poulch poulch added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240702080219.

Install it with:

pnpm add @saleor/[email protected]

@poulch poulch removed the release dev tag Release pkg to npm with @dev tag label Jul 2, 2024
@poulch poulch added the release dev tag Release pkg to npm with @dev tag label Jul 2, 2024
@poulch poulch dismissed stale reviews from andrzejewsky and krzysztofzuraw via 02da82f July 5, 2024 17:45
@poulch poulch added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240705175820.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240705180038.

Install it with:

pnpm add @saleor/[email protected]

Cloud11PL
Cloud11PL previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Cloud11PL Cloud11PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/BaseSelect/useHighlightedIndex.ts Outdated Show resolved Hide resolved
src/components/BaseSelect/useHighlightedIndex.ts Outdated Show resolved Hide resolved
@poulch poulch requested a review from Cloud11PL July 22, 2024 07:32
@poulch poulch merged commit df82ca9 into main Jul 22, 2024
10 checks passed
@poulch poulch deleted the fix-combobox-highlight-index branch July 22, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofzuraw krzysztofzuraw krzysztofzuraw approved these changes

@Cloud11PL Cloud11PL Cloud11PL approved these changes

@andrzejewsky andrzejewsky Awaiting requested review from andrzejewsky

Assignees
No one assigned
Labels
release dev tag Release pkg to npm with @dev tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poulch @andrzejewsky @krzysztofzuraw @Cloud11PL