Add correct commit author to Bitrise commits #646
Conversation
Bitrise does commits sometimes for us, like for example updating dependencies. Bitrise's documentation recommends to introduce an envvar with the values. These are the same values used in other projects. MOB-1696
gersonnoboa
requested review from
igorkravchenko,
EgorovEI,
rasmustautsglia and
yurii-glia
|
Changes are here https://github.com/salemove/ios-sdk-widgets/compare/MOB-1696?expand=1#diff-61d1ee831cb1df242161a7d23171914a1d5d628c7659b52db957d80a9394bd68R245, I don't know why the Bitrise format has been changed. |
There was a problem hiding this comment.
we worked with Rasmus on upload to AppStoreConnect task and I found that Bitrise stores configuration in another format, so decided to align with what we have in bitrise.yml just to avoid big diff in future.
however, if your editor think this is more correct format, we can leave. what editor do you use?
|
@yurii-glia I think the discrepancy comes when you save the file from Bitrise, vs when you copy the contents that Bitrise gives you and paste them yourself in the bitrise.yml. Or something liek that. They have had this issue for ages bitrise-io/bitrise-workflow-editor#572 |
|
!merge |
Bitrise does commits sometimes for us, like for example updating dependencies. Bitrise's documentation recommends to introduce an envvar with the values. These are the same values used in other projects.
MOB-1696