Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Kähler algebras as a category #39168

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from

Conversation

25shriya
Copy link
Contributor

@25shriya 25shriya commented Dec 19, 2024

This PR adds Kähler algebras as a category KahlerAlgebras as defined in Theorem 2.28 of this paper. It changes the category of Chow rings to KahlerAlgebras() & CommutativeRings().Quotients(). A method, lefschetz_element() is also implemented for Chow rings which returns a Lefschetz element as provided in Corollary 2.30 of the paper above, which is used for the Hodge-Riemann relations computation.

@tscrim

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Dec 19, 2024

Documentation preview for this PR (built with commit cac2378; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

src/sage/categories/kahler_algebras.py Show resolved Hide resolved
src/sage/categories/kahler_algebras.py Outdated Show resolved Hide resolved
src/sage/categories/kahler_algebras.py Outdated Show resolved Hide resolved
src/sage/categories/kahler_algebras.py Outdated Show resolved Hide resolved
src/sage/categories/kahler_algebras.py Outdated Show resolved Hide resolved
src/sage/matroids/chow_ring.py Outdated Show resolved Hide resolved
src/sage/matroids/chow_ring.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 9, 2025

Once the bot comes back green, you can set a positive review.

@tscrim
Copy link
Collaborator

tscrim commented Jan 9, 2025

One new (annoying) thing I think needs to be done is adding new files to the meson.build list file in the categories folder. Some modularity or porting thing that we have to explicitly maintain with extra work for something like this. I don't really understand it, but I think we now have to do it. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants