fixes for ruff warning C416 #38697
Merged
fixes for ruff warning C416 #38697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
suggested changes
Sep 22, 2024
| @@ -1325,8 +1325,8 @@ def bar(I): # transfer to O/pO | |||
|
|
|||
| def liftb(Ib): | |||
| m = [vector([fr(e) for e in v]) for v in Ib] | |||
| m += [v for v in pO._hnf] | |||
| return self._ideal_from_vectors_and_denominator(m,1) | |||
| m.append(list(pO._hnf)) | |||
There was a problem hiding this comment.
Are you sure it's the right form ? I think it should be m.extend(pO._hnf).
There was a problem hiding this comment.
oops, oui, désolé
|
Documentation preview for this PR (built with commit cb73962; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2024
this fixes almost every C416 warning from `ruff`
Unnecessary `list` comprehension (rewrite using `list()`)
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38697
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes almost every C416 warning from
ruffUnnecessary
listcomprehension (rewrite usinglist())📝 Checklist