[Certora Audit] G-06. ExtensibleFallbackHandler._supportsInterface(): save gas via short-circuit evaluation
#893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort-circuit evaluation
remedcu
changed the title
ExtensibleFallbackHandler._supportsInterface(): save gas via short-circuit evaluationExtensibleFallbackHandler._supportsInterface(): save gas via short-circuit evaluation
mmv08
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
ExtensibleFallbackHandlercontract in thecontracts/handler/ExtensibleFallbackHandler.solfile. The change modifies the_supportsInterfacefunction to reorder the interface checks forERC721TokenReceiver,ERC1155TokenReceiver, andIFallbackHandler. This helps in taking advantage of the short-circuit evaluation.Changes to interface support order:
contracts/handler/ExtensibleFallbackHandler.sol: Reordered the interface checks in the_supportsInterfacefunction to placeERC721TokenReceiverandERC1155TokenReceiverbeforeIFallbackHandler.