[Certora Audit] I-03. Inconsistency in formula for performCreate
and performCreate2
#887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commutativity makes the two additions equivalent but Certora recommend the fix below for
readability and to follow the standard given that:
deploymentData
gives a pointer to the start of the array (length position).0x20
skips the first 32 bytes (length field) to point directly to the start of the payload.Change:
contracts/libraries/CreateCall.sol
: Changed the order of parameters in thecreate2
function call to correctly add the offset todeploymentData
.