Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Certora Audit] I-03. Inconsistency in formula for performCreate and performCreate2 #887

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Jan 9, 2025

Commutativity makes the two additions equivalent but Certora recommend the fix below for
readability and to follow the standard given that:

  • deploymentData gives a pointer to the start of the array (length position).
  • Adding 0x20 skips the first 32 bytes (length field) to point directly to the start of the payload.

Change:

@remedcu remedcu self-assigned this Jan 9, 2025
@remedcu remedcu changed the title I-03. Inconsistency in formula for performCreate and performCreate2 [Certora Audit] I-03. Inconsistency in formula for performCreate and performCreate2 Jan 9, 2025
@remedcu remedcu marked this pull request as ready for review January 9, 2025 14:24
@remedcu remedcu requested review from akshay-ap and mmv08 January 9, 2025 14:25
@remedcu remedcu merged commit 8aa4551 into main Jan 9, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@mmv08 mmv08 deleted the i03 branch January 9, 2025 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants