-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Remove unused bytes from core contract's checkSignatures
method
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
requested review from
a team,
rmeissner,
nlordell and
akshay-ap
and removed request for
a team
October 31, 2023 10:57
nlordell
reviewed
Oct 31, 2023
mmv08
force-pushed
the
feature/remove-bytes-from-checksignatures
branch
from
October 31, 2023 10:59
f34eaf9
to
d36bfd4
Compare
Pull Request Test Coverage Report for Build 6707500820
💛 - Coveralls |
mmv08
force-pushed
the
feature/remove-bytes-from-checksignatures
branch
from
October 31, 2023 11:01
d36bfd4
to
e8463de
Compare
nlordell
reviewed
Oct 31, 2023
* and only accepts the data hash. | ||
* The data parameter (bytes) is not used since v1.5.0 as it is not required anymore. Prior to v1.5.0, | ||
* data parameter was used in contract signature validation flow using legacy EIP-1271. | ||
* Version v1.5.0, uses dataHash parameter instead of data with updated EIP-1271 implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would either mention that the data parameter is ignored, or require(keccak256(data) == dataHash)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment to the variable name
nlordell
reviewed
Oct 31, 2023
mmv08
force-pushed
the
feature/remove-bytes-from-checksignatures
branch
2 times, most recently
from
October 31, 2023 13:50
b6c9b05
to
70b2e75
Compare
…lity fallback handler
mmv08
force-pushed
the
feature/remove-bytes-from-checksignatures
branch
from
October 31, 2023 13:52
70b2e75
to
373cfd2
Compare
nlordell
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
bytes
parameter from the core contract's and adding the method with the old signature to theCompatibilityFallbackHandler