Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove unused bytes from core contract's checkSignatures method #693

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Oct 31, 2023

This PR:

  • Implements Remove the unused bytes parameter from the checkSignatures methods #687 by removing the bytes parameter from the core contract's and adding the method with the old signature to the CompatibilityFallbackHandler
  • Our change for the overloaded checkNSignatures method with the executor address came in handy when adding the backwards compatible method because we can grab the original sender's address and forward it to the method

@mmv08 mmv08 requested review from a team, rmeissner, nlordell and akshay-ap and removed request for a team October 31, 2023 10:57
@mmv08 mmv08 force-pushed the feature/remove-bytes-from-checksignatures branch from f34eaf9 to d36bfd4 Compare October 31, 2023 10:59
@coveralls
Copy link

coveralls commented Oct 31, 2023

Pull Request Test Coverage Report for Build 6707500820

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 95.208%

Totals Coverage Status
Change from base Build 6705456434: 0.9%
Covered Lines: 371
Relevant Lines: 380

💛 - Coveralls

@mmv08 mmv08 force-pushed the feature/remove-bytes-from-checksignatures branch from d36bfd4 to e8463de Compare October 31, 2023 11:01
@mmv08 mmv08 requested a review from nlordell October 31, 2023 12:32
* and only accepts the data hash.
* The data parameter (bytes) is not used since v1.5.0 as it is not required anymore. Prior to v1.5.0,
* data parameter was used in contract signature validation flow using legacy EIP-1271.
* Version v1.5.0, uses dataHash parameter instead of data with updated EIP-1271 implementation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would either mention that the data parameter is ignored, or require(keccak256(data) == dataHash).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment to the variable name

@mmv08 mmv08 force-pushed the feature/remove-bytes-from-checksignatures branch 2 times, most recently from b6c9b05 to 70b2e75 Compare October 31, 2023 13:50
@mmv08 mmv08 force-pushed the feature/remove-bytes-from-checksignatures branch from 70b2e75 to 373cfd2 Compare October 31, 2023 13:52
@mmv08 mmv08 requested a review from nlordell October 31, 2023 14:05
@mmv08 mmv08 merged commit 52ce39c into main Nov 1, 2023
18 checks passed
@mmv08 mmv08 deleted the feature/remove-bytes-from-checksignatures branch November 1, 2023 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants