Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused bytes parameter from the checkSignatures methods #687

Closed
mmv08 opened this issue Oct 24, 2023 · 0 comments
Closed

Remove the unused bytes parameter from the checkSignatures methods #687

mmv08 opened this issue Oct 24, 2023 · 0 comments
Assignees

Comments

@mmv08
Copy link
Member

mmv08 commented Oct 24, 2023

When working on the account specifications for the Safe{Core} Protocol, one of the requirements for the signature validators was the checkSignatures(bytes32, bytes, bytes) function, where the second bytes param is unused and comes from the legacy roots in the Safe.

Nick proposed that we remove this param from the requirements to not add "Tech debt" to accounts and update the Safe implementation accordingly.

Proposed solution

  • Update the functions in the safe core contract
  • Add old methods to the CompatibilityFallbackHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant