Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example of Passkey Executing Safe Transaction #499

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

nlordell
Copy link
Collaborator

This PR adds a "userstory" test that demonstrates how a passkey can be used to execute transactions directly on a Safe without going over ERC-4337.

It contains examples for both the shared signer, and signer factory.

@nlordell nlordell requested a review from a team as a code owner October 22, 2024 07:55
@nlordell nlordell requested review from akshay-ap, mmv08 and remedcu and removed request for a team October 22, 2024 07:55
@coveralls
Copy link

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 11456717523

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11323190278: 0.0%
Covered Lines: 92
Relevant Lines: 92

💛 - Coveralls

This PR adds a "userstory" test that demonstrates how a passkey can be
used to execute transactions directly on a Safe without going over
ERC-4337.
@nlordell nlordell force-pushed the chore/passkey-safe-tx-userstory branch from bbf01f3 to 8bb328c Compare October 22, 2024 08:05
Additionally, clarify that the transaction is executed by a relayer and
not natively by the passkey signer.
@nlordell nlordell merged commit f0af05c into main Oct 22, 2024
19 checks passed
@nlordell nlordell deleted the chore/passkey-safe-tx-userstory branch October 22, 2024 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants