Add Passkey Audit And Deploy Contracts #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
mmv08
reviewed
Jun 14, 2024
Pull Request Test Coverage Report for Build 9515069376Details
💛 - Coveralls |
mmv08
approved these changes
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Certora audit report for the passkey contracts and prepares the passkey contracts for deployment 🎉.
Note that there were a few details to take care of:
webauthn-sol. This included a small fix toecAff_isOnCurve.SafeWebAuthnSignerSingletoncontract was a bit tricky as theverify-etherscantask doesn't pick it up, since it is deployed in the constructor of theSafeWebAuthnSignerFactorycontractCHANGELOG.mdfile like we have for our other projects, which lists the expected addresses.