Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-starter-kit): Add owner management methods #949

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Aug 20, 2024

What it solves

Resolves #940

How this PR fixes it

Creating a BaseClient class with some core functionality as the owner management methods. We added as well some important ones as getSafeAddress or isSafeDeployed

@coveralls
Copy link

coveralls commented Aug 20, 2024

Pull Request Test Coverage Report for Build 10473498490

Details

  • 7 of 23 (30.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 77.282%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sdk-starter-kit/src/BaseClient.ts 4 20 20.0%
Totals Coverage Status
Change from base Build 10451434244: -0.8%
Covered Lines: 940
Relevant Lines: 1145

💛 - Coveralls

@yagopv yagopv requested a review from tmjssz August 20, 2024 14:30
@yagopv yagopv linked an issue Aug 20, 2024 that may be closed by this pull request
@yagopv yagopv merged commit cf6f033 into development Aug 21, 2024
20 checks passed
@yagopv yagopv deleted the feat/add-owner-management-methods branch August 21, 2024 07:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK Refactor] SDK Starter kit doesn't provide owner management methods
3 participants