feat: Extend SafeProviders externalClient type #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient` * Introduce `ExternalClient` type alias and use it as type for `#externalProvider` in SafeProvider * With the extended type we need to use viem methods individually from `viem/actions` instead of calling them directly on the client itself
…e4337Pack Also fix unit test for Safe4337Pack
Closed
|
No idea why the build in the pipeline is failing. There is no issue when running the build locally 🤔 |
This reverts commit 67acd8f.
…iem-migration-external-client-refactor
dasanra
approved these changes
Jul 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Addresses the feedback provided in this comment.
How this PR fixes it
This PR enhances the
SafeProviderby enabling it to support bothPublicClientandWalletClientas external providers.Key Changes:
ExternalClienthas been introduced, defined asPublicClient | ExternalSigner. This type is now used for the#externalProviderproperty inSafeProvider.viemmethods are now individually imported fromviem/actionsinstead of being directly invoked on the client.These changes ensure that
SafeProvidercan handle a broader range of external providers, enhancing its flexibility and functionality.