-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added centerSlide option for centering active slide #144
base: master
Are you sure you want to change the base?
Conversation
centerSlide option centers the current slide horizontally.
why has this not been merged yet? Is this project abandoned? |
Found that the above is not working properly, this is a little better; (in same position of code). Can probably be optimized tho..
|
This is a re-implementation of sachinchoolur#144
I found that this shifts the pager to the right, not sure why, but it certainly seems that it's pushing it to the right a 'half' space. Probably part of the changes to modify the width, it's effecting the positioning of the pager. |
Has this been implemented fully yet? I've added the lightslider.js file but breaks the layout and shifts to the right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, but only works when images have the exact same width (at least that's how it was in my tests)
I don't see any css rule lScenterSlide which should fix this issue. I still don't know how to center the picture and thumbnails if the picutre is smaller than the container |
This css code can center the thumbnail relative to the picture, when the number of thumbnail is not much: |
Oh,this pull request is seen 2015.
|
Can we merge this? |
It doesn't work, check that pr #227, works for me. |
This is my first git pull request, new to this!
Thanks