-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.4 compliance for v4 #296
Conversation
Hmmm - Edit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
============================================
+ Coverage 96.68% 96.71% +0.02%
- Complexity 115 117 +2
============================================
Files 13 13
Lines 483 487 +4
============================================
+ Hits 467 471 +4
Misses 16 16 ☔ View full report in Codecov by Sentry. |
I raised an issue with phpstan phpstan/phpstan#11634 https://www.php.net/manual/en/function.is-resource.php Note: When we use https://www.php.net/manual/en/function.stream-get-contents.php I added unit tests, and enhanced the checks, so that we throw the existing After this is reviewed, I will backport it to the v3 and v2 release series. It seems useful to make sure that we handle a closed resource as nicely as we can. |
Apply the small code changes and the CI and tooling changes for PHP 8.4 to master (which is where the v4 release series comes from).
And fixup
parse()
andexpect()
functions inService.php
- see the comments below about whatphpstan
noticed.Now, if someone passes a closed resource, we will throw the usual
ParseException
that is thrown when someone passes an empty input. Fixes issue #297