Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mark nullable parameter #128

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Explicitly mark nullable parameter #128

merged 1 commit into from
Jul 25, 2024

Conversation

cedric-anne
Copy link
Contributor

An occurence was missed in #126.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (a6cd725) to head (244b34b).
Report is 1 commits behind head on 5.1.

Additional details and impacted files
@@            Coverage Diff            @@
##                5.1     #128   +/-   ##
=========================================
  Coverage     99.72%   99.72%           
  Complexity      118      118           
=========================================
  Files             7        7           
  Lines           365      365           
=========================================
  Hits            364      364           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wonder how I missed that.

@phil-davis phil-davis merged commit baa3a1a into sabre-io:5.1 Jul 25, 2024
11 checks passed
@cedric-anne cedric-anne deleted the patch-1 branch July 26, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants