This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
test: add ASSET variable in Fork.t.sol to store forked asset
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
suggested changes
Feb 8, 2024
|
Note: this PR may cause a lot of conflicts on Should we merge this into |
I agree. If it's not a very critical issue (which I think it's not), even my opinion is to merge this PR against the staging branch. Do we all agree then? |
I personally agree |
smol-ninja
force-pushed
the
fix/asset-setup-fork-tests
branch
from
de1ac19 to
79c1f26
Compare
|
I've updated this against |
|
@andreivladbrg do you want to review it once more so that I can merge it into staging? It can be merged independently and I will update other PRs according to the changes introduced by this. |
andreivladbrg
force-pushed
the
staging
branch
from
1804e53 to
8276e73
Compare
andreivladbrg
force-pushed
the
fix/asset-setup-fork-tests
branch
2 times, most recently
from
071e97e to
87812a7
Compare
refactor: name default test asset to "dai" test: use low-level call to approve contract via approveContract() doc: add dev comment to USDC.t.sol and USDT.t.sol build: include ffi config in default foundry profile
andreivladbrg
force-pushed
the
fix/asset-setup-fork-tests
branch
from
87812a7 to
17ec78b
Compare
andreivladbrg
pushed a commit
that referenced
this pull request
Feb 15, 2024
* test: add "ASSET" variable in Fork.t.sol to store forked asset refactor: name default test asset to "dai" test: use low-level call to approve contract via approveContract() doc: add dev comment to USDC.t.sol and USDT.t.sole * test: define a computeMerkleLockupLLAddress without asset_ parameter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #286
Summary
assettodaiwhen referring to the default test asset.