Add protocol fee variable in claim and clawback functions
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: allow clawbacks when protocol fee greater than zero and campaign not expired test: update tests accordingly
|
Closing this PR because I used a wrong branch name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this scenario was not going to happen, as it would have been super bad to our business.
The idea behind this is to add one more layer of security for users in case the protocol fee is changed after an airstream campaign is created.
This would have been an issue if the expiration were set to 0, resulting in all funds being permanently locked and unable to be clawed back. Effectively, this would have allowed us to take a percentage of any airstream campaign that is created.