Update metadata before hook in cancel function #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses the following audit finding: |
andreivladbrg
force-pushed
the
fix/emit-event-before-hook
branch
from
d3d1e4e to
332124a
Compare
|
@PaulRBerg does it look good to you? |
andreivladbrg
added a commit
that referenced
this pull request
Dec 15, 2023
* fix: update metadata before hook in cancel * test: update Precompiles bytecode * chore: improve explanatory comment in dynamic contract * chore: simplify comments * test: update Precompiles bytecode --------- Co-authored-by: Paul Razvan Berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is to prevent DOS attacks when the recipient is a malicious contract and they could force excessive gas costs on the sender.