Merge pull request #718 from sablier-labs/refactor/emit-event-before-…

…hook

refactor: emit event before calling hooks

src/SablierV2LockupDynamic.sol

@@ -512,6 +512,9 @@ contract SablierV2LockupDynamic is
         // Interactions: refund the sender.
         asset.safeTransfer({ to: sender, value: senderAmount });
 
+        // Log the cancellation.
+        emit ISablierV2Lockup.CancelLockupStream(streamId, sender, recipient, asset, senderAmount, recipientAmount);
+
         // Interactions: if the recipient is a contract, try to invoke the cancel hook on the recipient without
         // reverting if the hook is not implemented, and without bubbling up any potential revert.
         if (recipient.code.length > 0) {
@@ -522,9 +525,6 @@ contract SablierV2LockupDynamic is
                 recipientAmount: recipientAmount
             }) { } catch { }
         }
-
-        // Log the cancellation.
-        emit ISablierV2Lockup.CancelLockupStream(streamId, sender, recipient, asset, senderAmount, recipientAmount);
     }
 
     /// @dev See the documentation for the user-facing functions that call this internal function.

src/SablierV2LockupLinear.sol

@@ -427,6 +427,9 @@ contract SablierV2LockupLinear is
         // Interactions: refund the sender.
         asset.safeTransfer({ to: sender, value: senderAmount });
 
+        // Log the cancellation.
+        emit ISablierV2Lockup.CancelLockupStream(streamId, sender, recipient, asset, senderAmount, recipientAmount);
+
         // Interactions: if the recipient is a contract, try to invoke the cancel hook on the recipient without
         // reverting if the hook is not implemented, and without bubbling up any potential revert.
         if (recipient.code.length > 0) {
@@ -437,9 +440,6 @@ contract SablierV2LockupLinear is
                 recipientAmount: recipientAmount
             }) { } catch { }
         }
-
-        // Log the cancellation.
-        emit ISablierV2Lockup.CancelLockupStream(streamId, sender, recipient, asset, senderAmount, recipientAmount);
     }
 
     /// @dev See the documentation for the user-facing functions that call this internal function.

src/abstracts/SablierV2Lockup.sol

@@ -202,15 +202,15 @@ abstract contract SablierV2Lockup is
         // Checks and Effects: renounce the stream.
         _renounce(streamId);
 
+        // Log the renouncement.
+        emit ISablierV2Lockup.RenounceLockupStream(streamId);
+
         // Interactions: if the recipient is a contract, try to invoke the renounce hook on the recipient without
         // reverting if the hook is not implemented, and also without bubbling up any potential revert.
         address recipient = _ownerOf(streamId);
         if (recipient.code.length > 0) {
             try ISablierV2LockupRecipient(recipient).onStreamRenounced(streamId) { } catch { }
         }
-
-        // Log the renouncement.
-        emit ISablierV2Lockup.RenounceLockupStream(streamId);
     }
 
     /// @inheritdoc ISablierV2Lockup