-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a util function to construct the create2 salt #814
Conversation
build: udpate multi chain script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I haven't tested the scripts locally though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea a lot - but we should absolutely test this new function in test/utils
.
I don't think is related to QuickNode, since in periphery worked: sablier-labs/v2-periphery#280 |
That looks like rate limiting imposed by Quicknode (2500 credits / sec). |
Bummer. Let's try another provider - I will switch to ChainNodes. Edit: done. |
chore: remove underscore from function name
note: it would require to include do you have any solution on how to fix this in the CI? how to include a flag in the command here: |
Yes. We can add |
c6fcc32
to
f8b85f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below
f8b85f1
to
04ed21e
Compare
@PaulRBerg does it look good now? can you approve the PR? will merge it once the CI is over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
This PR continues to be amazingly useful - @andreivladbrg you should tweet about it. |
Addresses #810
I decided to log the string salt to visually see what is being passed (also testing it, in case something is not working).
@smol-ninja, can you check, please, if I missed anything in the multi-chain script?