Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise readme #360

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Revise readme #360

wants to merge 12 commits into from

Conversation

DG12
Copy link
Contributor

@DG12 DG12 commented Feb 7, 2024

Beta =->production
remove reference to PVS

rearrange some steps to be more consistent with sequence of activities

DG12 added 11 commits November 8, 2021 23:19
@DG12
SDK 15.3 soft linking should be symbolic :-)
442cd22
@DG12
Delete src.tar.gz
c3d7832 
Already deleted from master
@DG12
Merge branch 'ruuvi:master' into master
af2774c
@DG12
Merge branch 'ruuvi:master' into master
08311f9
@DG12
remove test of unused(removed )functions in test_app_log
284517a 
remove test for unused functions: 
 *                      app_log_config_get/set
removed from src/app_log.c
@DG12
de minimis
a1645fb
@DG12
trailing space
638b506 
Argh!
@DG12
_enabled 1 -> true; interval 1-> (1U) and
79c4a56 
_enabled  1 -> true;  
_interval 1-> (1U) 

add comment at end of guard #endif
@DG12
deminis
e9cbbe7
@DG12
Delete PVS-Studio.cfg
b81c0ce
@DG12
Update README.md
d56cc80 
beta -> production

remove PVS

add suggested j-link

rearrange to be more consistent with order of activities
@ojousima
Copy link
Member

ojousima commented Feb 7, 2024

Thanks, are you using some editor for the file? I'm wondering how the
elements will look, I think that's not a part of markdown.

@DG12
Copy link
Contributor Author

DG12 commented Feb 8, 2024

I edited it in git hub.
Several lines ended up displaying as double spaced. I added BR html tags to those lines and now it renders OK. See
DG12firmware.c

@ojousima
Copy link
Member

ojousima commented Feb 8, 2024

I edited it in git hub.
Several lines ended up displaying as double spaced. I added BR html tags to those lines and now it renders OK. See
DG12firmware.c

Ok, thanks. I'll check the issues with SonarCloud and AStyle on Friday

@ojousima
Copy link
Member

ojousima commented Feb 9, 2024

The SonarCloud does not run because the pull request comes from your fork which does not have the required environment variables in GitHub, AStyle is a matter of running the script. I'll move the pull request over to Ruuvi's side and clear those up, your name will still be kept as the author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DG12 @ojousima