Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emproject dsp310missssing dot #327

Merged
merged 14 commits into from
Oct 4, 2024
Merged

emproject dsp310missssing dot #327

merged 14 commits into from
Oct 4, 2024

Conversation

DG12
Copy link
Contributor

@DG12 DG12 commented Feb 21, 2022

Just to be nice

@reviewpad reviewpad bot mentioned this pull request Mar 18, 2023
Merged
8 tasks
@reviewpad reviewpad bot added the small Pull request is small label Mar 18, 2023
@reviewpad reviewpad bot requested a review from ojousima March 18, 2023 10:10
@reviewpad
Copy link
Contributor

reviewpad bot commented Mar 18, 2023 •
edited
Loading

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'SDK 15.3 soft linking should be symbolic :-)' (442cd22)
  • Unconventional commit detected: 'Delete src.tar.gz

Already deleted from master' (c3d7832)

  • Unconventional commit detected: 'Merge branch 'ruuvi:master' into master' (af2774c)
  • Unconventional commit detected: 'Merge branch 'ruuvi:master' into master' (08311f9)
  • Unconventional commit detected: 'remove test of unused(removed )functions in test_app_log

remove test for unused functions:

  •                  app_log_config_get/set

removed from src/app_log.c' (284517a)

  • Unconventional commit detected: 'de minimis' (a1645fb)
  • Unconventional commit detected: 'trailing space

Argh!' (638b506)

  • Unconventional commit detected: '_enabled 1 -> true; interval 1-> (1U) and

_enabled 1 -> true;
_interval 1-> (1U)

add comment at end of guard #endif' (79c4a56)

  • Unconventional commit detected: 'dps310 filter needs dot

Only used in ruuvitag_b' (b1dc17f)

  • Unconventional commit detected: 'Merge branch 'master' into emprojectDSP310missssingDot' (f4f9c12)
  • Unconventional commit detected: 'Merge branch 'master' into emprojectDSP310missssingDot' (6d84908)
  • Unconventional commit detected: 'Restore tests' (d97ab45)
  • Unconventional commit detected: 'Remove comment after removing change the comment was related to' (a60cc99)
  • Unconventional title detected: 'emproject dsp310missssing dot' illegal 'e' character in commit message type: col=00

⚠️ Warnings

  • Please link an issue to the pull request
  • Please rebase your pull request on the latest changes

ojousima
ojousima approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@ojousima ojousima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry about late review

@reviewpad reviewpad bot requested a review from ojousima March 18, 2023 13:03
@ojousima ojousima merged commit a8f9cd8 into ruuvi:master Oct 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojousima ojousima ojousima approved these changes

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DG12 @ojousima