torch::optional->std::optional
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an alias since torch-2.4(and part of the standard since C++17), and there are plans to remove it in the future This change is generated by running `sed -i -e s/torch::optional/std::optional/` on the files in question
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 97.32% 97.28% -0.04%
==========================================
Files 11 11
Lines 224 221 -3
==========================================
- Hits 218 215 -3
Misses 6 6 ☔ View full report in Codecov by Sentry. |
|
See also #239 |
rusty1s
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an alias since torch-2.4(and part of the standard since C++17), and there are plans to remove it in the future
This change is generated by running
sed -i -e s/torch::optional/std::optional/on the files in question