Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pll: add default value for PllDdrControl and PllPeri0Control registers #17

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

Placebo27
Copy link
Contributor

Add impl Default for both structs PllDdrControl and PllPeri0Control, which returns the different default values:

  • The default value for PllDdrControl is 0x4800_2301.
  • The default value for PllPeri0Control is 0x4821_6300.

Add unit tests for above two default values using related register functions.

Add impl `Default` for both structs `PllDdrControl` and `PllPeri0Control`,
which returns the different default values:
  - The default value for `PllDdrControl` is `0x4800_2301`.
  - The default value for `PllPeri0Control` is `0x4821_6300`.
Add unit tests for above two default values using related register
functions.

Signed-off-by: DongQing <[email protected]>
@Placebo27 Placebo27 changed the title pll: add default value for PllDdrControl and PllPeri0Control registers pll: add default value for PllDdrControl and PllPeri0Control registers Nov 9, 2024
Copy link
Member

@luojia65 luojia65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the unit test values matches the Allwinner D1 User Manual, Version 1.0, Section 3.2.6.2 to 3.2.6.3. LGTM.

@luojia65 luojia65 merged commit 0adbda7 into rustsbi:main Nov 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants