Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create format, build and cargo test github actions #12

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

liyang8246
Copy link
Contributor

Actually, it’s an update to GitHub Action

look like it:
d632908f-2ff5-46c9-b2a7-673776256ab7

Copy link
Contributor

@Placebo27 Placebo27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In this pr, GitHub Actions' behavior conforms to the definition of this script.
But please abide by conventional commits to modify this pr, thx.
You can change github: to ci: .
It is also possible to rewrite the commit in more detail, for example, using ci: create format, build and cargo test github actions.

Actually, it’s an update to GitHub Action

Signed-off-by: liyang <[email protected]>
@liyang8246
Copy link
Contributor Author

LGTM! In this pr, GitHub Actions' behavior conforms to the definition of this script. But please abide by conventional commits to modify this pr, thx. You can change github: to ci: . It is also possible to rewrite the commit in more detail, for example, using ci: create format, build and cargo test github actions.

Thank you for the guidance! I’ve updated the PR to adhere to conventional commits by changing github: to ci: and have detailed the commit message as suggested.

@Placebo27
Copy link
Contributor

You may forget to amend the title, it's very important.

@liyang8246 liyang8246 changed the title github: create github actions ci: create format, build and cargo test github actions Oct 7, 2024
@liyang8246
Copy link
Contributor Author

You may forget to amend the title, it's very important.

😭

Copy link
Contributor

@Placebo27 Placebo27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

Copy link
Member

@luojia65 luojia65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luojia65 luojia65 merged commit 26dbc93 into rustsbi:main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants