-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: create format, build and cargo test github actions #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! In this pr, GitHub Actions' behavior conforms to the definition of this script.
But please abide by conventional commits to modify this pr, thx.
You can change github:
to ci:
.
It is also possible to rewrite the commit in more detail, for example, using ci: create format, build and cargo test github actions
.
Actually, it’s an update to GitHub Action Signed-off-by: liyang <[email protected]>
Thank you for the guidance! I’ve updated the PR to adhere to conventional commits by changing github: to ci: and have detailed the commit message as suggested. |
You may forget to amend the title, it's very important. |
😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually, it’s an update to GitHub Action
look like it: