Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to time-based errors #315

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Add details to time-based errors #315

merged 4 commits into from
Jan 28, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jan 28, 2025

Ala #301, but for time errors.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.46%. Comparing base (ae14fdd) to head (2b1cf9b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/error.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   97.42%   97.46%   +0.04%     
==========================================
  Files          20       20              
  Lines        4345     4345              
==========================================
+ Hits         4233     4235       +2     
+ Misses        112      110       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea 👏

@ctz ctz added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit a182fb0 Jan 28, 2025
63 of 64 checks passed
@ctz ctz deleted the jbp-time-error-detail branch January 28, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants