Fix invalid mapping to zero page caused by off-by-one bug #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `zero_end` bound is exclusive, but we treat the `end_page` as inclusive. So when `zero_end` is page-aligned, we allocate one additional bss page. If this page was already mapped to some other segment, we remap it to a page with random content. This is the same bug as #362.
|
Published as v0.9.27 🚀 |
|
Hi @phil-opp, thanks for the recent updates on the v0.9 branch! 🚀 There's a little issue with this last one, it should have removed the unused imports Would you like a quick PR fixing that? |
|
Ah, I missed that. Yes, a PR against the |
|
Great, working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zero_endbound is exclusive, but we treat theend_pageas inclusive. So whenzero_endis page-aligned, we allocate one additional bss page. If this page was already mapped to some other segment, we remap it to a page with random content.This is the same bug as #362.
Fixes phil-opp/blog_os#1297