Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft errors to minidump #138

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

marti4d
Copy link
Collaborator

@marti4d marti4d commented Oct 11, 2024

Fixes #31

@marti4d
Copy link
Collaborator Author

marti4d commented Oct 11, 2024

Obviously the (changes to minidump-common) need to land before this can work.

This is WIP for now, but review comments would still be appreciated. I tried to at least turn the 3 things that @gabrielesvelto pointed out into soft errors, but I also included some other stuff that I thought could be reasonably recovered from.

I didn't want to get too carried away, but I think there's probably even more stuff we could turn into soft errors... But I think this provides a good starting point!

Curious to hear what you think :)

Copy link
Contributor

@gabrielesvelto gabrielesvelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice! I've just left a few comments.

src/linux/minidump_writer.rs Outdated Show resolved Hide resolved
src/linux/minidump_writer.rs Outdated Show resolved Hide resolved
src/linux/minidump_writer.rs Outdated Show resolved Hide resolved
src/linux/ptrace_dumper.rs Show resolved Hide resolved
@marti4d
Copy link
Collaborator Author

marti4d commented Dec 13, 2024

@gabrielesvelto -- I think that should address your feedback. I changed the count to "18" (whoops), made "no threads left" a soft error, and recorded soft errors from trying to restart the threads.

The only thing I'm not sure about is your ergonomics improvement suggestion. Personally, I think I like the idea of using a trait to add two new functions to Result<T, E> called something like unwrap_or_record_and_then() and unwrap_or_record_and_default(), but I'm curious to hear if you think that it's worthwhile to do this?

@marti4d marti4d changed the title WIP: Add soft errors to minidump Add soft errors to minidump Jan 8, 2025
@marti4d marti4d force-pushed the soft_error branch 2 times, most recently from ccfb700 to e661a78 Compare January 8, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add soft errors to minidump
2 participants