Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future incompatibility warning unsupported_fn_ptr_calling_conventions: Also warn in dependencies #135767

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Future incompatibility warning unsupported_fn_ptr_calling_conventions: Also warn in dependencies #135767

wants to merge 2 commits into from
+617 −2

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Jan 20, 2025

Tracking issue: #130260

As discussed in the previous PR now the future incompatibility warning is enabled in dependencies.

The warning was added in 1.83, while this change will get into stable in 1.86, which gives crate authors three versions to fix the warning.

r? compiler-errors

@tdittr
After introducing the warning in 1.83, now also warn in deps
7e3ddaf 
This was left to only warn in the current crate to give users
a chance to update their code. Now for 1.86 we also warn users
depending on those crates.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@rustbot label: +I-lang-nominated +I-easy-decision

@bjorn3 bjorn3 added I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination labels Jan 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tdittr tdittr force-pushed the fn_ptr_calling_conventions-in-deps branch from 739dd7a to 55dc131 Compare January 21, 2025 09:33
@compiler-errors
Copy link
Member

Looks good to me but waiting on team approval

@compiler-errors compiler-errors added T-lang Relevant to the language team, which will review and decide on the PR/issue. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination I-lang-nominated Nominated for discussion during a lang team meeting. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tdittr @rust-log-analyzer @compiler-errors @bjorn3 @rustbot