Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create an issue template for bootstrap #135679

Merged
merged 1 commit into from
Jan 19, 2025
Merged

create an issue template for bootstrap #135679

merged 1 commit into from
Jan 19, 2025

Conversation

onur-ozkan
Copy link
Member

Resolves #135593

cc @rust-lang/bootstrap

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2025
@onur-ozkan onur-ozkan added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 18, 2025
@onur-ozkan onur-ozkan force-pushed the bootstrap-issue-template branch 2 times, most recently from 68bb8cd to fc86317 Compare January 18, 2025 08:45
@onur-ozkan onur-ozkan changed the title create a issue template for bootstrap create an issue template for bootstrap Jan 18, 2025
@onur-ozkan onur-ozkan force-pushed the bootstrap-issue-template branch from fc86317 to 10081e9 Compare January 18, 2025 10:38
@jieyouxu jieyouxu self-assigned this Jan 18, 2025
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2025
@rustbot

This comment has been minimized.

Sign in to view
@onur-ozkan onur-ozkan force-pushed the bootstrap-issue-template branch from 606e77c to a6d348b Compare January 19, 2025 09:02
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2025
jieyouxu
jieyouxu approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me with or without the nit

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2025
@onur-ozkan onur-ozkan force-pushed the bootstrap-issue-template branch from a6d348b to 660fd34 Compare January 19, 2025 10:05
@onur-ozkan onur-ozkan force-pushed the bootstrap-issue-template branch from 660fd34 to 59d7213 Compare January 19, 2025 10:06
jieyouxu
jieyouxu approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 19, 2025

📌 Commit 59d7213 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 19, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@bors
Auto merge of rust-lang#135725 - GuillaumeGomez:rollup-dxn3use, r=Gui…
af952c1 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134858 (Provide structured suggestion for `#![feature(..)]` in more cases)
 - rust-lang#135679 (create an issue template for bootstrap)
 - rust-lang#135685 (Remove unused `item-row` CSS class)
 - rust-lang#135716 (Don't skip argument parsing when running `rustc` with no arguments)
 - rust-lang#135723 (Fix dev guide docs for error-pattern)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 857bc5b into rust-lang:master Jan 19, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 19, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@rust-timer
Unrolled build for rust-lang#135679
89b0385 
Rollup merge of rust-lang#135679 - onur-ozkan:bootstrap-issue-template, r=jieyouxu

create an issue template for bootstrap

Resolves rust-lang#135593

cc `@rust-lang/bootstrap`
@onur-ozkan onur-ozkan deleted the bootstrap-issue-template branch January 19, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clubby789 clubby789 clubby789 left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

add issue template for issues with the build system or test suite.
6 participants
@onur-ozkan @rustbot @jieyouxu @bors @clubby789 @Mark-Simulacrum