Small rustc_resolve cleanups
#135677
Open
Small rustc_resolve cleanups
#135677
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Jan 18, 2025
| None | ||
| extern_crate_names.sort_by_key(|&name| Reverse(name)); | ||
|
|
||
| extern_crate_names |
There was a problem hiding this comment.
I feel like this is harder to read than the existing code. Can you revert it?
There was a problem hiding this comment.
Yeah, you're right, also doesn't fit the commit it was in. Reverted.
There was a problem hiding this comment.
Using Reverse here was actually wrong because I was ordering by Symbol (which orders by index) instead of its string repr. Unfortunately I had to revert to sort_by because of lifetime issues, but at least I could still use total ordering instead of partial.
yotamofek
force-pushed
the
resolve-cleanups2
branch
from
eb10a58 to
a909520
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2025
…piler-errors Small `rustc_resolve` cleanups 1. Don't open-code `Reverse` 2. Use slice patterns where possible
yotamofek
force-pushed
the
resolve-cleanups2
branch
from
a909520 to
d913c37
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135616 (CI: split i686-msvc job to two free runners) - rust-lang#135623 (ci: use ghcr ubuntu image for mingw-check-tidy) - rust-lang#135640 (Drop MIPS glibc 2.23 patches that reside in crosstool-ng now) - rust-lang#135663 (Fix ICE in resolving associated items as non-bindings) - rust-lang#135677 (Small `rustc_resolve` cleanups) - rust-lang#135680 (coverage: Clean up a few things after the counters overhaul) - rust-lang#135697 (Get rid of `ToPolyTraitRef`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse