ci: mirror buildkit image to ghcr #135624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Huh. This means that if The bash script is a bit larger now, but we expected that; adding new images to the list shouldn't make it more complicated, so I think it's fine. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133700 (const-eval: detect more pointers as definitely not-null) - rust-lang#135290 (Encode constraints that hold at all points as logical edges in location-sensitive polonius) - rust-lang#135478 (Run clippy for rustc_codegen_gcc on CI) - rust-lang#135583 (Move `std::pipe::*` into `std::io`) - rust-lang#135612 (Include x scripts in tarballs) - rust-lang#135624 (ci: mirror buildkit image to ghcr) - rust-lang#135661 (Stabilize `float_next_up_down`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2025
Rollup merge of rust-lang#135624 - marcoieni:mirror-buildkit-image, r=Kobzol ci: mirror buildkit image to ghcr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #135574 we successfully mirrored the
ubuntu:22.04image in ghcr to allowmingw-check-tidyworking without Docker caching.However, I found out that all CI jobs pull an additional image from the dockerhub, i.e.
moby/buildkit:buildx-stable-1.You can see this from the logs of the
mingw-check-tidyjob:I saw jobs failing in #133912 because they failed to pull this image for the dockerhub rate limit.
So this PR mirrors this additional image in ghcr 👍
To use it, we need to add the flag
--driver-opt image=ghcr.io/marcoieni/buildkit:buildx-stable-1todocker buildx create --use --driver docker-container(I tested this in #133912).If you think this bash script is becoming too complex, I can rewrite the script in python as I did in #135530
r? @Kobzol