Enable `unreachable_pub` lint in core #134286

Urgau · 2024-12-13T22:04:27Z

This PR enables the unreachable_pub as warn in core, rtstartup and panic_unwind.

The motivation is similar to the compiler MCP: Enable deny(unreachable_pub) on rustc_* crates :

"Where is this thing used?" is a question I ask all the time when reading unfamiliar code. Because of this, I generally find it annoying when things are marked with a more permissive visibility than necessary. "This thing marked pub, which other crates is it used in? Oh, it's not used in any other crates."

Another motivation is to help to lint by utilizing it in-tree and seeing it's limitation in more complex scenarios.

The diff was mostly generated with ./x.py fix --stage 1 library/core/ -- --broken-code, as well as manual edits for code in macros, generated code and other targets.

r? libs

ibraheemdev · 2024-12-27T06:46:21Z

This seems reasonable to me, does it need libs signoff?

Urgau · 2024-12-27T10:22:08Z

I don't know T-libs customs around enabling new lints. Given that T-compiler as done an MCP I guess it doesn't hurt to at least nominate it.

@rustbot labels -S-waiting-on-review +S-waiting-on-team +I-libs-nominated

library/core/src/lib.rs

Amanieu · 2025-01-15T17:21:06Z

We discussed this in the libs meeting today, overall several people were in favor of enabling the lint and nobody objected.

ibraheemdev · 2025-01-16T05:58:02Z

@bors r+

bors · 2025-01-16T05:58:04Z

📌 Commit 2fa6dbc has been approved by ibraheemdev

It is now in the queue for this repository.

Urgau · 2025-01-20T18:42:11Z

Fixed the error and rebased. CI is green. Let's try again.

@bors r=ibraheemdev

bors · 2025-01-20T18:42:13Z

📌 Commit 15f345b has been approved by ibraheemdev

It is now in the queue for this repository.

bors · 2025-01-20T23:34:08Z

⌛ Testing commit 15f345b with merge a42d5ec...

bors · 2025-01-21T02:22:06Z

☀️ Test successful - checks-actions
Approved by: ibraheemdev
Pushing a42d5ec to master...

rust-timer · 2025-01-21T03:53:16Z

Finished benchmarking commit (a42d5ec): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.999s -> 765.476s (0.06%)
Artifact size: 326.01 MiB -> 326.00 MiB (-0.00%)

Enable `unreachable_pub` lint in `test` and `proc_macro` crates This PR enables the [`unreachable_pub`](https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#unreachable-pub) lint as warn in the `test` and `proc_macro` crates. The diff was mostly generated with `./x.py fix --stage 1 library/proc_macro/ -- --broken-code`, as well as manual edits for code in macros and in tests. Continuation of rust-lang#134286 r? libs

Rollup merge of rust-lang#135366 - Urgau:unreach_pub-std-2, r=cuviper Enable `unreachable_pub` lint in `test` and `proc_macro` crates This PR enables the [`unreachable_pub`](https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#unreachable-pub) lint as warn in the `test` and `proc_macro` crates. The diff was mostly generated with `./x.py fix --stage 1 library/proc_macro/ -- --broken-code`, as well as manual edits for code in macros and in tests. Continuation of rust-lang#134286 r? libs

Enable `unreachable_pub` lint in `alloc` This PR enables the [`unreachable_pub`](https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#unreachable-pub) lint as warn in the `alloc` crate. Most of changes are in the btree implementation and in tests. *The diff was mostly generated with `./x.py fix --stage 1 library/alloc/ -- --broken-code`, as well as manual edits for code in macros and in tests.* Continuation of rust-lang#134286 and rust-lang#135366 r? libs

Rollup merge of rust-lang#135367 - Urgau:unreach_pub-std-3, r=Noratrieb Enable `unreachable_pub` lint in `alloc` This PR enables the [`unreachable_pub`](https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#unreachable-pub) lint as warn in the `alloc` crate. Most of changes are in the btree implementation and in tests. *The diff was mostly generated with `./x.py fix --stage 1 library/alloc/ -- --broken-code`, as well as manual edits for code in macros and in tests.* Continuation of rust-lang#134286 and rust-lang#135366 r? libs

…, r=Noratrieb Fix `unreachable_pub` lint for hermit target The build for the hermit target (`#[cfg(target_os = "hermit")]`) fails on master as of [8df89d1](rust-lang@8df89d1) (2025-02-05), due to introducing `#[warn(unreachable_pub)]` at the root in rust-lang#134286 (Enable unreachable_pub lint in core, merged 2025-01-20). Make the relevant visibility modifiers more specific to resolve the warning. ``` $ ./x build --target x86_64-unknown-hermit Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.34s Building stage0 library artifacts (x86_64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.15s Building compiler artifacts (stage0 -> stage1, x86_64-apple-darwin) Finished `release` profile [optimized] target(s) in 1.67s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 library artifacts {alloc, core, panic_abort, panic_unwind, proc_macro, std, sysroot, test, unwind} (x86_64-apple-darwin -> x86_64-unknown-hermit) Compiling panic_unwind v0.0.0 (library/panic_unwind) error: unreachable `pub` item --> library/panic_unwind/src/hermit.rs:10:9 | 10 | pub fn __rust_abort() -> !; | ---^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> library/panic_unwind/src/hermit.rs:17:9 | 17 | pub fn __rust_abort() -> !; | ---^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `panic_unwind` (lib) due to 2 previous errors Build completed unsuccessfully in 0:00:39 ```

Rollup merge of rust-lang#136595 - thaliaarchi:hermit-unreachable-pub, r=Noratrieb Fix `unreachable_pub` lint for hermit target The build for the hermit target (`#[cfg(target_os = "hermit")]`) fails on master as of [8df89d1](rust-lang@8df89d1) (2025-02-05), due to introducing `#[warn(unreachable_pub)]` at the root in rust-lang#134286 (Enable unreachable_pub lint in core, merged 2025-01-20). Make the relevant visibility modifiers more specific to resolve the warning. ``` $ ./x build --target x86_64-unknown-hermit Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.34s Building stage0 library artifacts (x86_64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.15s Building compiler artifacts (stage0 -> stage1, x86_64-apple-darwin) Finished `release` profile [optimized] target(s) in 1.67s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 library artifacts {alloc, core, panic_abort, panic_unwind, proc_macro, std, sysroot, test, unwind} (x86_64-apple-darwin -> x86_64-unknown-hermit) Compiling panic_unwind v0.0.0 (library/panic_unwind) error: unreachable `pub` item --> library/panic_unwind/src/hermit.rs:10:9 | 10 | pub fn __rust_abort() -> !; | ---^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]` error: unreachable `pub` item --> library/panic_unwind/src/hermit.rs:17:9 | 17 | pub fn __rust_abort() -> !; | ---^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates error: could not compile `panic_unwind` (lib) due to 2 previous errors Build completed unsuccessfully in 0:00:39 ```

rustbot assigned ibraheemdev Dec 13, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 13, 2024

This comment has been minimized.

Sign in to view

Urgau force-pushed the unreach_pub-std branch from ea66587 to 1001c68 Compare December 13, 2024 22:15

This comment has been minimized.

Sign in to view

Urgau force-pushed the unreach_pub-std branch from 1001c68 to 9f3e1d8 Compare December 13, 2024 22:32

This comment has been minimized.

Sign in to view

Urgau force-pushed the unreach_pub-std branch from 9f3e1d8 to 8a52a33 Compare December 13, 2024 22:46

This comment has been minimized.

Sign in to view

Urgau force-pushed the unreach_pub-std branch from 8a52a33 to 3b475dd Compare December 13, 2024 23:04

This comment was marked as resolved.

Sign in to view

Urgau force-pushed the unreach_pub-std branch from 3b475dd to 0fbf070 Compare January 1, 2025 12:13

This comment was marked as resolved.

Sign in to view

Urgau force-pushed the unreach_pub-std branch from 0fbf070 to ef31b57 Compare January 8, 2025 18:58

klensy reviewed Jan 8, 2025

View reviewed changes

library/core/src/lib.rs Show resolved Hide resolved

Urgau force-pushed the unreach_pub-std branch from ef31b57 to 2fa6dbc Compare January 10, 2025 17:51

This was referenced Jan 11, 2025

Enable unreachable_pub lint in test and proc_macro crates #135366

Merged

Enable unreachable_pub lint in alloc #135367

Merged

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2025

Urgau added 4 commits January 20, 2025 18:35

panic_unwind: add #![warn(unreachable_pub)]

477ef65

rtstartup: add #![warn(unreachable_pub)]

0f30662

core: add #![warn(unreachable_pub)]

8e61502

core: #[allow(unreachable_pub)] on unreachable pub use

15f345b

Urgau force-pushed the unreach_pub-std branch from f1c6898 to 15f345b Compare January 20, 2025 17:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 21, 2025

bors merged commit a42d5ec into rust-lang:master Jan 21, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 21, 2025

This was referenced Jan 21, 2025

Add f16 formatting and parsing #127013

Draft

Add some track_caller info to precondition panics #129658

Draft

setup typos check in CI #134006

Open

dec2flt: Clean up float parsing modules #134063

Open

thaliaarchi mentioned this pull request Feb 5, 2025

Fix unreachable_pub lint for hermit target #136595

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable `unreachable_pub` lint in core #134286

Enable `unreachable_pub` lint in core #134286

Urgau commented Dec 13, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ibraheemdev commented Dec 27, 2024

Urgau commented Dec 27, 2024

This comment was marked as resolved.

This comment was marked as resolved.

Amanieu commented Jan 15, 2025

ibraheemdev commented Jan 16, 2025

bors commented Jan 16, 2025

Urgau commented Jan 20, 2025

bors commented Jan 20, 2025

bors commented Jan 20, 2025

bors commented Jan 21, 2025

rust-timer commented Jan 21, 2025

Enable unreachable_pub lint in core #134286

Enable unreachable_pub lint in core #134286

Conversation

Urgau commented Dec 13, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ibraheemdev commented Dec 27, 2024

Urgau commented Dec 27, 2024

This comment was marked as resolved.

This comment was marked as resolved.

Amanieu commented Jan 15, 2025

ibraheemdev commented Jan 16, 2025

bors commented Jan 16, 2025

Urgau commented Jan 20, 2025

bors commented Jan 20, 2025

bors commented Jan 20, 2025

bors commented Jan 21, 2025

rust-timer commented Jan 21, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Enable `unreachable_pub` lint in core #134286

Enable `unreachable_pub` lint in core #134286