This repository has been archived by the owner on Jun 27, 2018. It is now read-only.
Add restrictive seccomp whitelist #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be integrated into how the server is compiled and/or executes docker? As is it seems difficult to deploy and not well integrated. |
|
My understanding is that Docker expects the JSON file to actually exist on the filesystem, but that file could be created at runtime. |
|
Yes creating the file at runtime would be ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a restrictive seccomp whitelist. This was a major security loss when Playpen was replaced by Docker.
This requires that
whitelist.jsonbe placed in the working directory of the process. Not sure how to arrange for that. That file is generated fromwhitelistbyconvert.py. I used the same whitelist as was used back when Playpen was the sandbox.