Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis Windows build #215

Merged
merged 3 commits into from
Nov 17, 2018
Merged

Add Travis Windows build #215

merged 3 commits into from
Nov 17, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Nov 7, 2018

This adds the Windows build to Travis.

I had to use the dos2unix utility on the parser directory to fix some incorrect
line endings. I'm not sure where they are coming from but I guess git is
converting them automatically when cloning on Windows.

Closes #139

@phansch
Copy link
Member Author

phansch commented Nov 7, 2018

I should mention that the windows build takes about 14 minutes because installing rust-docs via rustup is really slow on windows.

@matklad
Copy link
Member

matklad commented Nov 7, 2018

because installing rust-docs via rustup is really slow on windows.

Can we somehow tell rustup not to download docs?

@phansch
Copy link
Member Author

phansch commented Nov 7, 2018

It's not possible, yet. I can't find the most recent discussion right now, but it's being tracked in rustup: rust-lang/rustup#906.

edit: This is more recent: rust-lang/rustup#998

@matklad
Copy link
Member

matklad commented Nov 7, 2018

Hm, I think a good idea then is to run windows build only on the master branch, and not gate CI on windows build.

And I think we might remove appveyour.yml and the badge from readme?

The Windows build is much slower than Linux, so we only build it on master
and make the build status not depend on it finishing up.
@phansch
Copy link
Member Author

phansch commented Nov 7, 2018

Should be ready now. I moved the windows build to allow_failure, which means master will be green once the rust linux and npm tests have passed.

Not sure why it is still showing the status for AppVeyor on cb659cd, maybe it has to be merged first.

@phansch
Copy link
Member Author

phansch commented Nov 7, 2018

Ok, looks like AppVeyor picked up on the missing appveyor.yml and fails accordingly 😆

The build phase is set to "MSBuild" mode (default), but no Visual Studio project or solution files were found in the root directory.

@@ -29,6 +33,12 @@ matrix:
- cd editors/code && npm ci && npm run travis

allow_failures:
- os: windows
if: branch = master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, will it actually include this in the test matrix? Let's see I guess :)

@matklad
Copy link
Member

matklad commented Nov 17, 2018

bors r+

Thanks!

bors bot added a commit that referenced this pull request Nov 17, 2018
215: Add Travis Windows build r=matklad a=phansch

This adds the Windows build to Travis.

I had to use the `dos2unix` utility on the parser directory to fix some incorrect
line endings. I'm not sure where they are coming from but I guess git is
converting them automatically when cloning on Windows.

Closes #139 

Co-authored-by: Philipp Hansch <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 17, 2018

Build succeeded

@bors bors bot merged commit cb659cd into rust-lang:master Nov 17, 2018
@matklad
Copy link
Member

matklad commented Nov 17, 2018

Hm, it doesn't actually build windows on master:

image

Perhaps we need to add something like

 - os: windows
 - branch: master

to the matrix?

@CAD97
Copy link
Contributor

CAD97 commented Nov 17, 2018

Yep, you'll need to keep the build job in the matrix.include. The same formulation as in the allow_failures should work:

- os: windows
  if: branch = master

Then I'd change allow_failures to just be

- os: windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from appveyor to travis for windows testing
3 participants