-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Travis Windows build #215
Conversation
I should mention that the windows build takes about 14 minutes because installing |
Can we somehow tell rustup not to download docs? |
It's not possible, yet. I can't find the most recent discussion right now, but it's being tracked in rustup: rust-lang/rustup#906. edit: This is more recent: rust-lang/rustup#998 |
Hm, I think a good idea then is to run windows build only on the master branch, and not gate CI on windows build. And I think we might remove appveyour.yml and the badge from readme? |
The Windows build is much slower than Linux, so we only build it on master and make the build status not depend on it finishing up.
Should be ready now. I moved the windows build to Not sure why it is still showing the status for AppVeyor on cb659cd, maybe it has to be merged first. |
Ok, looks like AppVeyor picked up on the missing appveyor.yml and fails accordingly 😆
|
@@ -29,6 +33,12 @@ matrix: | |||
- cd editors/code && npm ci && npm run travis | |||
|
|||
allow_failures: | |||
- os: windows | |||
if: branch = master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, will it actually include this in the test matrix? Let's see I guess :)
bors r+ Thanks! |
215: Add Travis Windows build r=matklad a=phansch This adds the Windows build to Travis. I had to use the `dos2unix` utility on the parser directory to fix some incorrect line endings. I'm not sure where they are coming from but I guess git is converting them automatically when cloning on Windows. Closes #139 Co-authored-by: Philipp Hansch <[email protected]>
Build succeeded |
Yep, you'll need to keep the build job in the - os: windows
if: branch = master Then I'd change - os: windows |
This adds the Windows build to Travis.
I had to use the
dos2unix
utility on the parser directory to fix some incorrectline endings. I'm not sure where they are coming from but I guess git is
converting them automatically when cloning on Windows.
Closes #139