Skip to content

Commit

Permalink
Auto merge of #135273 - dianne:argument-patterns-are-not-boring, r=lqd
Browse files Browse the repository at this point in the history
Remove special-casing for argument patterns in MIR typeck (attempt to fix perf regression of  #133858)

See [my comment](rust-lang/rust#133858 (comment)) on #133858 for more information. This is just a guess as to what went wrong, and I haven't been able to get the profiler running locally, so I'll need a perf run to make sure this actually helps.

There's one test's stderr that suffers a bit, but this was just papering over the issue anyway. Making region errors point to the correct constraints in the presence of invariance/contravariance is a broader problem; the current way it's handled is mostly based on guesswork, luck, and hoping it works out. Properly handling that (somehow) would improve the test's stderr without the hack that this PR reverts.
  • Loading branch information
bors committed Jan 10, 2025
2 parents 41ca9b7 + f22e634 commit 25eb566
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 25eb566

Please sign in to comment.